Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx: Skip caching WP API #855

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

tangrufus
Copy link
Collaborator

Submit a feature request or bug report

Replace any X with your information.


What is the current behavior?

Nginx caches WP API responses and serving them to everyone without checking authorizations.

What is the expected or desired behavior?

Nginx should skip caching WP API responses

@swalkinshaw
Copy link
Member

Makes sense 👍

@swalkinshaw swalkinshaw merged commit 529069c into roots:master Jul 31, 2017
@mAAdhaTTah
Copy link
Contributor

It is possible to change the prefix programmatically with a filter in WordPress. Does that need to be taken into consideration here?

@tangrufus
Copy link
Collaborator Author

@mAAdhaTTah
When changing wp api prefix with filters, they need to follow https://roots.io/trellis/docs/fastcgi-caching/

cache:
  skip_cache_uri: <Change here>

Maybe we need to update the docs?

@tangrufus tangrufus deleted the nginx-skip-wp-json-caching branch August 13, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants