Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vagrant_box_version to <= 201801.02.0 #938

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

tangrufus
Copy link
Collaborator

See: https://app.vagrantup.com/bento/boxes/ubuntu-16.04


Question:
The box is ubuntu-16.04. Should we use lower-bound version constraint instead of upper-bound?
I.e.: Will this be better?

vagrant_box_version: '>= 201801.02.0'

@swalkinshaw
Copy link
Member

>= makes it easier for people to keep their box up to date and should be fine, but I guess there's a small chance some update could break Trellis. I would assume the likelyhood of that happening would be very low though?

@swalkinshaw
Copy link
Member

Going to merge this as is for now and we can see about flipping it after.

@swalkinshaw swalkinshaw merged commit b983c6d into roots:master Jan 19, 2018
@tangrufus tangrufus deleted the patch-1 branch January 19, 2018 16:33
tangrufus added a commit to tangrufus/trellis that referenced this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants