Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xdebug.remote_autostart to simplify xdebug sessions #985

Merged
merged 3 commits into from
Apr 29, 2018

Conversation

nathanielks
Copy link
Contributor

This adds an additional flag to simplify using Xdebug locally. Instead of requiring a certain HTTP header or $_REQUEST value, setting xdebug.remote_autostart=1 tells Xdebug to attempt a connection with a debugger regardless of their presence.

@swalkinshaw
Copy link
Member

Makes sense to me 👍

@nathanielks
Copy link
Contributor Author

@swalkinshaw Changelog added

@nathanielks nathanielks merged commit 6ac097c into master Apr 29, 2018
@nathanielks nathanielks deleted the xdebug-autostart branch April 29, 2018 22:03
@glopena
Copy link

glopena commented May 5, 2018

Hi,

I'm getting the trace below when running a production deployment.

Why is this running into the production deployment pipeline?

TASK [sshd : Create a secure sshd_config] *********************************************************************************************************************
System info:
Ansible 2.5.2; Darwin
Trellis at "Add xdebug.remote_autostart to simplify xdebug sessions"

failed to validate
/root/.ansible/tmp/ansible-tmp-1525542800.36-18644436872727/source line 20:
Bad SSH2 mac spec '[email protected],hmac-
[email protected],hmac-
[email protected],[email protected],hmac-sha2-512,hmac-
sha2-256,hmac-ripemd160'.

fatal: [46.101.42.219]: FAILED! => {"changed": false, "checksum": "b7d35e56697beb3eef26812f86f681f3e098045c", "exit_status": 255, "stderr_lines": ["/root/.ansible/tmp/ansible-tmp-1525542800.36-18644436872727/source line 20: Bad SSH2 mac spec '[email protected],[email protected],[email protected],[email protected],hmac-sha2-512,hmac-sha2-256,hmac-ripemd160'."], "stdout": "", "stdout_lines": []}

@fullyint
Copy link
Contributor

fullyint commented May 5, 2018

@glopena The server.yml playbook for provisioning is not running xdebug. The System info: section of the output indicates version for Ansible, OS, and Trellis. I realize it could appear that Trellis at "Some CHANGELOG entry" could appear to be an indication of where the error occured, but the intended message is "Trellis at version, indicated by latest entry in the CHANGELOG.md". That is background to explain that the error you ran into is not actually related to this old merged PR.

I am able to reproduce the Bad SSH2 mac spec message if I run Trellis on Ubuntu 18.04, which apparently comes with OpenSSH_7.6p1 in which the the hmac-ripemd160 MAC is no longer supported (props to this investigation into the error).

Although we'll soon offer support for the recently released Ubuntu 18.04, Trellis is only intended for 16.04 at this time. This is indicated in the README.md and docs.

I'd recommend using Ubuntu 16.04 for the sake of proven Trellis compatibility. If you are using 18.04 and want to continue with it, you could avoid the Bad SSH2 mac spec error by overriding the sshd_macs_default variable, omitting the two ripemd160 entries. For example, add the following to group_vars/all/main.yml:

sshd_macs_default:
  - [email protected]
  - [email protected]
  - [email protected]
  - hmac-sha2-512
  - hmac-sha2-256

Then rerun the server.yml playbook.

@glopena
Copy link

glopena commented May 6, 2018

Thank you Phil.
That was exactly the issue. Took me a few hours to figure it out on my own only to see I had your response awaiting to be read. Apologies for the rookie mistake. It's been a lot to take in.

Again, a huge thank you for your time and knowledge. Truly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants