Deploy: Remove obsoleted git remote checking
#999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you able to verify the behaviour? Or should we try and do that first? |
tangrufus
commented
Jul 2, 2018
| - name: Clone project files | ||
| git: | ||
| repo: "{{ project_git_repo }}" | ||
| dest: "{{ project_source_path }}" | ||
| version: "{{ project_version }}" | ||
| accept_hostkey: "{{ project.repo_accept_hostkey | default(repo_accept_hostkey | default(true)) }}" | ||
| force: yes |
There was a problem hiding this comment.
Side Effect
Before this pull request:
If /srv/www/XXXX/shared/source being modified, deploy will fail. And, no useful message printed because of no_log: true. Instead, a misleading Git repo {{ project.repo }} cannot be accessed will be printed on the next task.
After this pull request:
If /srv/www/XXXX/shared/source being modified, the changes will be discarded during deploy because of force: yes.
There was a problem hiding this comment.
I think that's better anyway 👍
Remove obsoleted `git` remote checking tasks introduced in roots#299 because recent Ansible versions are able to detect/handle `git` remote changes. See: https://discourse.roots.io/t/do-we-still-need-git-remote-checking-during-deploy/12639
|
Seems like a good thing to merge |
|
Tests changing between 2 repos(one with subtree and one without) back and forth. It looks good to me. Did anyone find any bugs? |
|
Perfect, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove obsoleted
gitremote checking tasks introduced in #299 because recent Ansible versions are able to detect/handlegitremote changes.See: https://discourse.roots.io/t/do-we-still-need-git-remote-checking-during-deploy/12639