Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 6.1 #53

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Support Rails 6.1 #53

merged 4 commits into from
Dec 14, 2020

Conversation

santib
Copy link
Member

@santib santib commented Jul 19, 2020 •
edited
Loading

  • Wait until Rails 6.1 is released

@santib santib force-pushed the rails-6-1-support branch 3 times, most recently from 948cb5d to 9c791bf Compare July 19, 2020 01:07
@drewrodrigues
Copy link

@santib Any updates here? Having issues with Rails 6

@santib
Copy link
Member Author

santib commented Oct 6, 2020

@santib Any updates here? Having issues with Rails 6

Hi @thesimpledev, Actually the versions 1.0.0 and 1.1.0 of this gem do already work with Rails 6 😄 You can see a working sample app here https://github.com/Ricoch/Issue55Example

This PR is to add support to Rails 6.1 which hasn't yet been released https://rubygems.org/gems/rails/versions

@santib santib force-pushed the rails-6-1-support branch 3 times, most recently from c77948f to 05276eb Compare December 13, 2020 18:48
@santib santib requested a review from a team December 13, 2020 18:54
jpascual1994
jpascual1994 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@jpascual1994 jpascual1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@santib santib requested a review from a team December 14, 2020 13:00
santib
santib commented Dec 14, 2020
View reviewed changes
active_storage_base64.gemspec
@@ -12,10 +12,10 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/rootstrap/active-storage-base64'
s.email = '[email protected]'

s.required_ruby_version = '>= 2.2.2'
s.required_ruby_version = '>= 2.5.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was just to match Rails required ruby version

@santib santib merged commit b1e0c68 into master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjaimem martinjaimem martinjaimem approved these changes

@jpascual1994 jpascual1994 jpascual1994 approved these changes

@juanmanuelramallo juanmanuelramallo juanmanuelramallo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@santib @drewrodrigues @juanmanuelramallo @jpascual1994 @martinjaimem