Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/ Add some notes on Readme #911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enhancement/ Add some notes on Readme #911

wants to merge 2 commits into from

Conversation

davidgk
Copy link

@davidgk davidgk commented Aug 5, 2022 •
edited
Loading 

* Add some notes to README to improve the experience about running
  locally:
  * redis local conf
  * how to run with docker-compose
* enhance .env test example to allow running tests

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Trying to run it locally I found a couple of issues that maybe helps to be aware.

Issue Link: N/A

What is the new behavior?

Improve Knowledge about how to run it.

@davidgk
enhancement/ Add some notes on Readme
5f7ef09 
    * Add some notes to README to improve the experience about running
      locally:
      * redis local conf
      * how to run with docker-compose
@davidgk davidgk force-pushed the enhancement_Add-some-notes-on-Readme branch from a194e4e to 5f7ef09 Compare August 5, 2022 20:33
@davidgk davidgk requested review from EMazzaglia and removed request for MatiasDelorenzi August 5, 2022 20:36
@davidgk davidgk marked this pull request as ready for review August 5, 2022 20:36
@davidgk davidgk requested a review from a team as a code owner August 5, 2022 20:36
@davidgk davidgk requested review from pablanco, Alxzu and diebarral and removed request for a team August 5, 2022 20:36
EMazzaglia
EMazzaglia approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@EMazzaglia EMazzaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMazzaglia EMazzaglia EMazzaglia approved these changes

@pablanco pablanco Awaiting requested review from pablanco pablanco is a code owner automatically assigned from rootstrap/reviewers-express-api-base

@Alxzu Alxzu Awaiting requested review from Alxzu Alxzu is a code owner automatically assigned from rootstrap/reviewers-express-api-base

@diebarral diebarral Awaiting requested review from diebarral diebarral is a code owner automatically assigned from rootstrap/reviewers-express-api-base

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgk @EMazzaglia