Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ctags_install() failure due to unused argument fileext #75

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

thomaszwagerman
Copy link
Contributor

Replaces fileext with ext in ctags-install.R.

fs::temp_file() expects ext.

Successfully install ctags.

Closes #74

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @thomaszwagerman !

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (e6c0d98) to head (e66c1d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          27       27           
  Lines        3358     3358           
=======================================
  Hits         2832     2832           
  Misses        526      526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpadge mpadge merged commit f035d53 into ropensci-review-tools:main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctags_install() fails due to unused argument fileext which should be ext
2 participants