-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to scan multiple paths at once #35
Conversation
Thanks @chartgerink, looks awesome! I probably won't get time to have a good look until next week, unfortunately. In the meantime some responses to your questions:
That was the only outstanding question i had thinking about this. I don't know an answer, and since you're the first person who has thought to use this pkg that way, I'm happy for you to decide what's best for you there.
Those counts are used to order the list of contributors, and i think it would likely be generally better to keep the ordering throughout. So yes, i think contributions should be summed. They're always extracted anyway, so doing that should be pretty straightforward. I'd suggest replacing your current I'll look further next week. Thanks 🚀 (You also should rename |
Thanks @mpadge 😊 I will take another pass and push an update this week so you have it before you take a deeper look. I appreciate the clarity with which you are communicating your capacity - a week is still very fast! |
A bit later than promised, but I added the changes you suggested.
Thanks for allowing me to make a suggestion 🙏 I currently hardcoded the return of the organization in the first repository path provided, but happy to adjust. It doesn't look particularly approachable because of the PS: I'm coming back to R after several years of not actively developing so pardon my sloppiness. I'm still in NodeJS mode so wrangling some of the R objects is still a bit of a struggle. 😅 |
Again, sorry @chartgerink that this ended up taking much longer than I originally suggested. I'll merge now, and then just make a couple of minor tweaks. All of your contributions will appear in an updated CRAN version asap. Thank you so much for your work, and engagement with the package - I really appreciate it! |
This PR adds the option to supply a vector of paths for the
repo
argument. This allows for creating contributor lists across a range of repositories at once (example: for an entire organization). This is in relation to #34.In this PR the following is changed:
add_contributors_one_repo
functionadd_contributors
function now takes a vector ofrepo
paths (but still works with only one path too)Open questions for consideration are:
I appreciate the opportunity to contribute - the above questions were a bit unforeseen from my end. I am open to any and all suggestions, also if that means ending up not including this code at all. Look forward to hearing what you think and what questions come up 😊