Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guess_fileSize() does not handle regexp like ^docs$ #299

Closed
ThierryO opened this issue Aug 16, 2020 · 2 comments
Closed

guess_fileSize() does not handle regexp like ^docs$ #299

ThierryO opened this issue Aug 16, 2020 · 2 comments
Labels

Comments

@ThierryO
Copy link
Member

files in this line contains the full path, hence ^ fails as it is should be relative to the root of the package.

Unlike R CMD build, it doesn't handle folder names. IMHO ^docs$ should ignore only the docs folder at the root of the package and all its files.

@maelle
Copy link
Member

maelle commented Aug 17, 2020

Thanks, good catch too, and same question, any interest in doing a PR? (no worries if not, but I prefer knowing before diving into it myself 🙂 )

@maelle maelle added the bug label Aug 17, 2020
@ThierryO
Copy link
Member Author

I'll start working on this PR first. Then on #298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants