Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledgement of authorship / contributors #388

Closed
KlausVigo opened this issue Feb 15, 2022 · 4 comments
Closed

Acknowledgement of authorship / contributors #388

KlausVigo opened this issue Feb 15, 2022 · 4 comments
Assignees
Milestone

Comments

@KlausVigo
Copy link

Hello all,

I am not sure if this is the right place for this request. I observed now several times during review for MEE and recently rOpenSci that functions or code has been copied without proper acknowledgement. There are of course two simple solutions either import the function (which also avoids code duplication) or adding the authors of the function as contributors (see below). I myself contacted several times authors to add a function in one of my packages and always had positive feedback. This would allow the authors of such a contribution to claim these as a "broader impact" with funding authorities, etc.

This situation could be avoided if there would be a statement in the devguide similar to one of the first paragraphs of the CRAN Repository Policy:

"The ownership of copyright and intellectual property rights of all components of the package must be clear and unambiguous (including from the authors specification in the DESCRIPTION file). Where code is copied (or derived) from the work of others (including from R itself), care must be taken that any copyright/license statements are preserved and authorship is not misrepresented.

Preferably, an ‘Authors@R’ field would be used with ‘ctb’ roles for the authors of such code. Alternatively, the ‘Author’ field should list these authors as contributors.

Where copyrights are held by an entity other than the package authors, this should preferably be indicated via ‘cph’ roles in the ‘Authors@R’ field, or using a ‘Copyright’ field (if necessary referring to an inst/COPYRIGHTS file).

Trademarks must be respected."

Kind regards,
Klaus

@assignUser
Copy link

that functions or code has been copied without proper acknowledgement

This is actually in most cases a violation of the original authors copyright (with most packages on CRAN using MIT/GPL/BSD). As the minimum would be to retain the copyright notice/license info. Contacting the authors is nice but not required.
If the original code is GPL licensed you would also need to license your entire package as GPL!

The proper adherence to license conditons should be enforced by rOpensci during review.

I do like the idea of additionally mentioning those authors as ctb in the DESCRIPTION in the spirit of allcontributors

@mpadge
Copy link
Member

mpadge commented Mar 7, 2022

@KlausVigo: @maelle and I have discussed this, and agree that this is a very important point to explicitly state in the DevGuide. Would you like to submit a PR adding your suggestions? It is also important to mention the potential for license conflicts, such as those raised by @assignUser, and to make a statement that authors should/must ensure that all potential or actual conflicts have been satisfactorily resolved through explicit and sufficiently detailed acknowledgements and modifications to DESC files. Thanks!

@maelle
Copy link
Member

maelle commented Mar 7, 2022

Just noting that PRs are best made against the dev branch. Thanks in any case for the issue!

@mpadge
Copy link
Member

mpadge commented May 9, 2022

Done via #459

@mpadge mpadge closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants