Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JOSS instrucctions #187

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Update JOSS instrucctions #187

merged 2 commits into from
Sep 26, 2019

Conversation

noamross
Copy link
Contributor

@noamross noamross commented Aug 5, 2019

As pointed out in openjournals/joss-reviews#1622, one doesn't use the Zenodo DOI to submit to JOSS, this is handled later. Added some instructions to allow the author to expedite the review themselves. @arfon

Copy link
Contributor

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think we need to be explicit about submitting the repo link and not the link to the Zenodo archive of the code?

@noamross
Copy link
Contributor Author

noamross commented Aug 5, 2019

This is the form. I guess we can be more explicit by specifying the "rOpenSci GitHub URL"
Screenshot 2019-08-05 16 11 22

Copy link
Contributor

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍looks good!

@melvidoni
Copy link
Contributor

LGTM. Do you think we need to be explicit about submitting the repo link and not the link to the Zenodo archive of the code?

The problem, @annakrystalli, is that an author had a lot of confusion about this, and when they asked JOSS they got this information. Some people may want to follow instructions exactly just to be sure to not mess up, but we are basically being misleading. It is a simple fix, I think, and @noamross nailed it.

@annakrystalli
Copy link
Contributor

Hey @melvidoni. Yes I agree, that's what I meant, to be more explicit.

@sckott sckott added this to the 0.3.0 milestone Sep 26, 2019
@sckott sckott merged commit eeeb302 into dev Sep 26, 2019
@sckott sckott deleted the joss-submit-fix branch September 26, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants