Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation to ES of review.md #303

Merged
merged 4 commits into from
Jan 25, 2021
Merged

translation to ES of review.md #303

merged 4 commits into from
Jan 25, 2021

Conversation

FvD
Copy link

@FvD FvD commented Jan 18, 2021

Fix #301

@maelle
Copy link
Member

maelle commented Jan 18, 2021

🙏 muchas gracias

@maelle
Copy link
Member

maelle commented Jan 18, 2021

I'll add the template to the book (via editing one Rmd) myself once the review has been approved by one native speaker. Thanks a ton again!

Copy link
Member

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @FvD!

In addition to the changes I suggest here, I also suggest some changes to the English version (@maelle I mentioned you in a few places; let me know if you want me to follow up with a PR). Also, I think both versions would benefit from wrapping at 80 characters -- that make it easier for a reviewer to see exactly what changed when someone fixes a typo.

templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Outdated Show resolved Hide resolved
templates/review-es.md Show resolved Hide resolved
@maelle maelle merged commit b74ddb9 into ropensci:dev Jan 25, 2021
@maelle
Copy link
Member

maelle commented Jan 25, 2021

Thanks @FvD & @maurolepore!

@maelle
Copy link
Member

maelle commented Jan 25, 2021

(changes made in the English version too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants