Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @noamross suggested modification to family tag text #361

Merged
merged 3 commits into from
Nov 18, 2021
Merged

add @noamross suggested modification to family tag text #361

merged 3 commits into from
Nov 18, 2021

Conversation

mpadge
Copy link
Member

@mpadge mpadge commented Nov 18, 2021

No description provided.

@mpadge mpadge requested a review from maelle November 18, 2021 10:01
maelle
maelle requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please update the changelog in appendix.Rmd as well?

pkg_building.Rmd Outdated Show resolved Hide resolved
@maelle maelle merged commit 281de94 into ropensci:dev Nov 18, 2021
@maelle
Copy link
Member

maelle commented Nov 18, 2021

Thanks a lot @mpadge!

@mpadge mpadge requested a review from maelle November 18, 2021 14:04
@maelle maelle added this to the 0.8.0 milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelle maelle Awaiting requested review from maelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mpadge @maelle