Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fetch gps points from all & more than one page (osm_get_points_gps()) #29

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jmaspons
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.01%. Comparing base (2ed94fb) to head (29d830d).
Report is 2 commits behind head on main.

Files Patch % Lines
R/osm_get_points_gps.R 98.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   92.87%   93.01%   +0.14%     
==========================================
  Files          26       27       +1     
  Lines        2160     2219      +59     
==========================================
+ Hits         2006     2064      +58     
- Misses        154      155       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The API call make batches of 5.000 points.
Private traces without url can be separated in different items in the
result if they get split due to server pagination
@jmaspons jmaspons merged commit 24c573a into main Jun 19, 2024
9 checks passed
@jmaspons jmaspons deleted the autopagination_gps_points branch June 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant