Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The coming improvement of minty "breaks" NA tests #194

Closed
chainsawriot opened this issue Jul 3, 2024 · 1 comment
Closed

The coming improvement of minty "breaks" NA tests #194

chainsawriot opened this issue Jul 3, 2024 · 1 comment

Comments

@chainsawriot
Copy link
Collaborator

The upcoming minty update (not yet on CRAN) has improvement on NA handling gesistsa/minty#11.

But this test is basically testing the buggy NA parsing behavior of readr::type_convert()

readODS/tests/testthat/test_na.R

Line 35 in 7847a22

expect_false(any(is.na(na_res$ex4[1:9])))

@chainsawriot chainsawriot changed the title The coming improvement of minty' might "break" NA tests The coming improvement of minty might "break" NA tests Jul 3, 2024
@chainsawriot chainsawriot changed the title The coming improvement of minty might "break" NA tests The coming improvement of minty "breaks" NA tests Jul 3, 2024
@chainsawriot
Copy link
Collaborator Author

We have to first disable the test. Submit readODS to CRAN first, and then minty.

chainsawriot added a commit that referenced this issue Jul 18, 2024
@chainsawriot
Fix #194
befc750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chainsawriot