-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes various issues #1
Conversation
- Added LazyData - Removed maintainers (cre is fine as maintainer) - Formatted License correctly - Added sp to imports over Depends
Also forgot to mention that you shouldn't edit |
Many thanks @karthik, this does indeed fix various issues. I am new to package development, so your input is really appreciated. I have just pushed some changes that I think fix the issues for the
|
Shorten and simplify examples for viaroute
update to latest version
Hi @Robinlovelace
Here is a small PR with various fixes. References ropensci/software-review#10
There are some issues with the examples failing checks but perhaps something you are working on?
For functions in:
recat-NTS.R
, where do the variablesb, c
get referenced from inage_recat2
anddisab_recat
? You should pass those explicitly.Here is my
session_info()