Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes various issues #1

Merged
merged 6 commits into from
Apr 18, 2015
Merged

Fixes various issues #1

merged 6 commits into from
Apr 18, 2015

Conversation

karthik
Copy link
Member

@karthik karthik commented Apr 18, 2015

Hi @Robinlovelace
Here is a small PR with various fixes. References ropensci/software-review#10
There are some issues with the examples failing checks but perhaps something you are working on?
For functions in: recat-NTS.R, where do the variables b, c get referenced from in age_recat2 and disab_recat? You should pass those explicitly.

Here is my session_info()

> session_info()
Session info --------------------------------------------------------------------------------
 setting  value                       
 version  R version 3.1.3 (2015-03-09)
 system   x86_64, darwin13.4.0        
 ui       RStudio (0.99.386)          
 language (EN)                        
 collate  en_US.UTF-8                 
 tz       America/Los_Angeles         

Packages ------------------------------------------------------------------------------------
 package    * version    date       source                            
 devtools     1.7.0      2015-01-17 CRAN (R 3.1.2)                    
 digest     * 0.6.8      2014-12-31 CRAN (R 3.1.2)                    
 evaluate   * 0.6        2015-04-13 CRAN (R 3.1.3)                    
 foreign    * 0.8-63     2015-02-20 CRAN (R 3.1.2)                    
 jsonlite   * 0.9.16     2015-04-11 CRAN (R 3.1.3)                    
 knitr        1.9        2015-01-20 CRAN (R 3.1.2)                    
 lattice    * 0.20-31    2015-03-30 CRAN (R 3.1.3)                    
 maptools   * 0.8-34     2015-02-03 CRAN (R 3.1.2)                    
 Rcpp       * 0.11.5     2015-03-06 CRAN (R 3.1.3)                    
 rgdal      * 0.9-1      2014-09-18 CRAN (R 3.1.2)                    
 rgeos      * 0.3-8      2014-09-21 CRAN (R 3.1.2)                    
 rmarkdown    0.5.1      2015-01-26 CRAN (R 3.1.2)                    
 roxygen2   * 4.1.0      2014-12-13 CRAN (R 3.1.2)                    
 rstudioapi * 0.3.1      2015-04-07 CRAN (R 3.1.3)                    
 sp           1.0-17     2015-01-08 CRAN (R 3.1.2)                    
 stplanr      0.0.0.9005 <NA>       local                             
 stringr    * 0.6.2      2012-12-06 CRAN (R 3.1.0)  

@karthik
Copy link
Member Author

karthik commented Apr 18, 2015

Also forgot to mention that you shouldn't edit NAMESPACE directly. Only edit the roxygen tags and let document() take care of updating it.

Robinlovelace added a commit that referenced this pull request Apr 18, 2015
@Robinlovelace Robinlovelace merged commit d08cffc into ropensci:master Apr 18, 2015
@Robinlovelace
Copy link
Member

Many thanks @karthik, this does indeed fix various issues. I am new to package development, so your input is really appreciated. I have just pushed some changes that I think fix the issues for the *recat functions - inconsistent use of variable names in previous versions! Thanks for pointing that out. Only remaining warning on my system now is WARNING LaTeX errors when creating PDF version. Not too serious. My session info is:

Session info ---------------------------------------------------------------------------------
 setting  value                       
 version  R version 3.2.0 (2015-04-16)
 system   i686, linux-gnu             
 ui       RStudio (0.99.386)          
 language en_GB:en                    
 collate  en_US.UTF-8                 
 tz       <NA>                        

Packages -------------------------------------------------------------------------------------
 package    * version    date       source        
 devtools     1.7.0      2015-01-17 CRAN (R 3.2.0)
 digest     * 0.6.8      2014-12-31 CRAN (R 3.2.0)
 foreign    * 0.8-61     2014-03-28 CRAN (R 3.0.3)
 jsonlite   * 0.9.16     2015-04-11 CRAN (R 3.2.0)
 lattice    * 0.20-29    2014-04-04 CRAN (R 3.1.0)
 maptools   * 0.8-26     2013-08-07 CRAN (R 3.0.1)
 memoise    * 0.2.1      2014-04-22 CRAN (R 3.2.0)
 Rcpp       * 0.11.5     2015-03-06 CRAN (R 3.2.0)
 rgdal      * 0.9-2      2015-03-15 CRAN (R 3.2.0)
 rgeos      * 0.2-19     2013-06-22 CRAN (R 3.0.1)
 roxygen2   * 4.1.1      2015-04-15 CRAN (R 3.2.0)
 rstudioapi * 0.3.1      2015-04-07 CRAN (R 3.2.0)
 sp         * 1.0-11     2013-06-30 CRAN (R 3.0.1)
 stplanr      0.0.0.9005 <NA>       local         
 stringr    * 0.6.2      2012-12-06 CRAN (R 3.2.0)

Robinlovelace added a commit that referenced this pull request Nov 12, 2015
Robinlovelace pushed a commit that referenced this pull request Sep 1, 2016
Shorten and simplify examples for viaroute
Robinlovelace pushed a commit that referenced this pull request Jul 22, 2019
update to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants