New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace checks for columns with class identifier #46

Closed

lmullen opened this issue Oct 16, 2015 · 0 comments

Milestone

Member

lmullen commented Oct 16, 2015

From rOpenSci onboarding

Perhaps it makes sense to give pairwise candidate dataframes their own class for assertion testing, rather than testing on column names, as in lsh_compare().

lmullen added this to the v0.1.0 milestone

lmullen added a commit that referenced this issue


          Replace column checks with class identifier

453b410

Fixes #46

lmullen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment