Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alias API version beta == v1 #114

Merged
merged 4 commits into from
Jun 28, 2019
Merged

add alias API version beta == v1 #114

merged 4 commits into from
Jun 28, 2019

Conversation

dlebauer
Copy link
Collaborator

@dlebauer dlebauer commented Jun 19, 2019

Description

In the last release I forgot to merge in this minor change.

We've created an v1 that will eventually replace our /beta endpoint. We currently maintain both for backward compatibility, but have started using v1 in our tutorials and documentation that were based on the terraref/traits fork. It would be nice to be able to write code that uses the v1 end point instead of the beta endpoint.

Would it be possible to push this to CRAN as a v0.4.1 'hotfix' so that our current tutorials will work with the official version on cran?

Example

This should work:

options(
        betydb_url = "https://terraref.ncsa.illinois.edu/bety/",
        betydb_api_version = 'v1')
canopy_height <- betydb_search(trait     = "canopy_height",
                               sitename  = "~Season 6",
                               limit     = "1"
                               )

this change didn't make it into the last release - any chance it could be released as a 'hotfix' so we can begin migrating to using v1?
@dlebauer
Copy link
Collaborator Author

(failing tests are from traitbank and shouldn't be affected by this PR)

@dlebauer
Copy link
Collaborator Author

@kimberlyh66 could you please check that this fixes the issues you were having?

@kimberlyh66
Copy link

@dlebauer yes, this fixes the problem that I was having

Not sure if this is correct / what to do with the trailing .9100 ...
@kimberlyh66
Copy link

v1 now works, but need API key

@sckott
Copy link
Contributor

sckott commented Jun 25, 2019

@dlebauer is this ready to look at?

@dlebauer
Copy link
Collaborator Author

yes this is ready to push out to CRAN!

@sckott sckott added this to the v0.4.2 milestone Jun 28, 2019
@sckott sckott merged commit 7652dd8 into ropensci:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants