Skip to content

Commit

Permalink
yf_get now gives warnings() for assets with one row -- fixes #23
Browse files Browse the repository at this point in the history
Merge branch 'main' of github.com:ropensci/yfR

# Conflicts:
#	NEWS.md
  • Loading branch information
msperlin committed Dec 6, 2022
2 parents 5c6f430 + c2bee13 commit df3afe6
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: yfR
Title: Downloads and Organizes Financial Data from Yahoo Finance
Version: 1.0.4
Version: 1.0.5
Authors@R: c(person("Marcelo", "Perlin", email = "[email protected]", role = c("aut", "cre")),
person("Nic", "Crane", role = "rev",
comment = "Nic reviewed the package (v. 0.0.5) for
Expand Down Expand Up @@ -34,7 +34,8 @@ Imports:
magrittr,
humanize,
methods,
pingr
pingr,
tidyselect
License: MIT + file LICENSE
LazyData: true
RoxygenNote: 7.2.2
Expand Down
6 changes: 5 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## Version 1.0.5 (2022-12-06) -- bug fixes
## Version 1.0.6 (2022-12-06) -- bug fixes

- fix for when user is requesting one trading day. Now it gives a warning and not an error -- [fixes #23](https://github.com/ropensci/yfR/issues/23)

## Version 1.0.5 (2022-11-23) -- bug fixes

- now using tidyselect::all_of() (fixes [issue #22](https://github.com/ropensci/yfR/issues/22))

## Version 1.0.4 (2022-11-15) -- bug fixes

- switched curl::has_internet by pingr::is_online() -- the first doesn't seem to work on restricted networks. Fixes [#20](https://github.com/ropensci/yfR/issues/20)
Expand Down
2 changes: 1 addition & 1 deletion R/yf_data_convert_to_wide.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ yf_convert_to_wide <- function(df_in) {
temp_df_wide <- tidyr::pivot_wider(
data = temp_df,
names_from = ticker,
values_from = tidyr::all_of(name_in)
values_from = tidyselect::all_of(name_in)
)

return(temp_df_wide)
Expand Down
1 change: 1 addition & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,4 @@ dontrun
donttest
TSLA
pingr
tidyselect

0 comments on commit df3afe6

Please sign in to comment.