Changes up to divest v0.8.1 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Stable Release (v1.0.20190410)
jonclayden
commented
May 7, 2019
| tinydir_dir dir; | ||
| int count = 0; | ||
| if (tinydir_open_sorted(&dir, path) != 0) | ||
| return -1; |
There was a problem hiding this comment.
It may be worth adopting this tinydir call in the mainline implementation. I have seen infinite recursion when relying on dir.has_next, because the body of the loop itself creates new files.
There was a problem hiding this comment.
Added to development (rather than master) branch. Will evaluate dir.has_next for mainline.
neurolabusc
added a commit
that referenced
this pull request
May 17, 2019
yarikoptic
added a commit
to neurodebian/dcm2niix
that referenced
this pull request
May 6, 2020
* tag 'v1.0.20190720': Update dcm_qa submodule. Handle rare VRs (https://www.aliza-dicom-viewer.com/download/datasets) New default merge option "-m o" will merge CTs and segment MRIs (https://discourse.slicer.org/t/odd-dicom-import/7576) --progress option (rordenlab#314; rordenlab#312) Tune verbosity (rordenlab#312) GE Slice Timing From Protocol Data Block (rordenlab#311) Desparate guess of GE slice times from ProtocolDataBlock (clone dicm2nii, assumes TA close to TR) Support interleaved (rordenlab#309) Slice times from ucMode (rordenlab#309) GE number of slice discrepancy (rordenlab#306) Simplify slice timing code, develop stc validation (https://github.com/neurolabusc/dcm_qa_stc) hdr.vox_offset is a float not integer (https://www.nitrc.org/forum/message.php?msg_id=27155) BIDS tags for PASL fairest sequent Read 0019,1029 (rordenlab#296) Generate warning rather than error when palette colors are detected (UNFmontreal/Dcm2Bids#54) Update tinydir call (rordenlab#298) Bruker 4D datasets: correct slice ordering Bruker 4D datasets: Fix parametric maps grouping Changes up to divest v0.8.1 Support isotropic scans for NRRD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remerges the
divestcodebase with the main one. It mostly addsdivest-specific implementation details, but also makes some compatibility fixes and avoids callingexit(), which will quit R.