GE Direct field mapping (TE1/TE2) (#617) #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neurolabusc
reviewed
Jul 20, 2022
console/nii_dicom_batch.cpp
Outdated
| if ((d.TE > 0.0) && (!d.isXRay)) { | ||
| if ((d.manufacturer == kMANUFACTURER_GE) && (d.isRealIsPhaseMapHz) && (d.velocityEncodeScaleGE < 0)) { //issue617, only set for GE fieldmaphz | ||
| json_Float(fp, "\t\"EchoTime1\": %g,\n", d.TE / 1000.0 ); | ||
| json_Float(fp, "\t\"EchoTime2\": %g,\n", d.TE / 1000.0 - 1/(2 * M_PI * d.velocityEncodeScaleGE)); |
There was a problem hiding this comment.
Can I suggest you change
json_Float(fp, "\t\"EchoTime2\": %g,\n", d.TE / 1000.0 - 1/(2 * M_PI * d.velocityEncodeScaleGE));
to read
json_Float(fp, "\t\"EchoTime2\": %g,\n", d.TE / 1000.0 - 1.0/(2.0 * M_PI * d.velocityEncodeScaleGE));
I think for C the constant 1 is an integer and the constant 1.0 is a float. I think it gets promoted by the computation, but it keeps your code more consistent with my style.
|
Here are the updates. Please let me know if you have any comments. Thanks! |
neurolabusc
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the changes, especially for the "only set for GE fieldmaphz", please let me know if you have any suggestions.