add MAGNITUDE to ImageType for GE data #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpinsard the |
bpinsard
force-pushed
the
fix/ge_magnitude
branch
from
7f8d1d2
to
743378c
Compare
bpinsard
force-pushed
the
fix/ge_magnitude
branch
from
743378c
to
08aeeef
Compare
|
Sorry I forgot the git-flow, rebased and move it to development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That change is necessary for heudiconv logic in
heudiconv.convert.update_complex_nametriggeringRuntimeError("Data type could not be inferred from the metadata.").https://github.com/nipy/heudiconv/blob/68231ef2dc9bfc603c2f925c3ec00c98dd6681b4/heudiconv/convert.py#L334-L340
Otherwise, it would require heudiconv to assume
MAGNITUDEby default, while we reliably have that information from the dicoms at the conversion stage.