Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Refactoring #179

Merged
merged 10 commits into from
Feb 9, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 9, 2024

similar to ros-controls/ros2_controllers#1028

RHEL/Debian

  • Build and test only the packages from this repo, instead of all packages imported with the repos file. I used colcon list instead of hardcoding it as it is done with the lint jobs.
  • Split build and test steps, and let the test step continue-on-error: The main goal is to detect compilation problems with unsupported C++ features, which are now visible at first glance. Tests remain flaky on theses platforms, which is a different issue.
  • use reusable workflows for both platforms
  • use a semi-binary build for RHEL

others

  • add reviewer lottery
  • Remove coverage builds for iron/humble (they are all on the same branch as rolling)
  • Use reusable-industrial-ci-with-cache.yml as with the other repos
  • use matrix strategy instead of duplicating workflow files

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf19ce0) 50.10% compared to head (4f246b6) 50.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #179   +/-   ##
============================================
  Coverage        50.10%   50.10%           
============================================
  Files               10       10           
  Lines              497      497           
  Branches           167      167           
============================================
  Hits               249      249           
  Misses             217      217           
  Partials            31       31           
Flag Coverage Δ
unittests 50.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bmagyar bmagyar merged commit 21dc7a5 into ros-controls:ros2-master Feb 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants