[CI] Update pre-commit and remove ros-lint #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #187 +/- ##
============================================
Coverage 50.10% 50.10%
============================================
Files 10 10
Lines 497 497
Branches 166 167 +1
============================================
Hits 249 249
Misses 217 217
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
changed the title
christophfroehlich
changed the title
Co-authored-by: Felix Exner (fexner) <[email protected]>
bmagyar
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ros-lint CI job but change configuration of pre-commit to run the linters with the ci-format job (renamed to ci-pre-commit) as discussed here.
Do we need the matrix strategy here, or is it sufficient to check on rolling distro?
Format fails until #188 gets merged