Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controllers] Enable services for setting the log-level in controller per default #1102

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Aug 17, 2023

This is very useful when debugging and now supported in rolling and iron.

For more info see:
https://docs.ros.org/en/rolling/Tutorials/Demos/Logging-and-logger-configuration.html#logger-level-configuration-externally

@bijoua29
Copy link
Contributor

Note, although this PR is necessary to add logging service to controllers, it will not work immediately since the node option to enable logging service is not implemented for lifecycle nodes. It is being worked on and should be fixed by this PR.

@bmagyar
Copy link
Member

bmagyar commented Aug 17, 2023

Shouldn't we do this on configure instead? These services add a way to block controllers...

@bijoua29
Copy link
Contributor

bijoua29 commented Sep 16, 2023

Can we get this PR approved and merged? Implementation looks fine to me. Currently, I can't modify the log level of controllers at run-time

@bmagyar
Copy link
Member

bmagyar commented Sep 16, 2023

There was a question just above without a reply from anyone... 🤷

@bijoua29
Copy link
Contributor

Shouldn't we do this on configure instead? These services add a way to block controllers...

This change is to enable a node option to enable the log level service. It must be set when the node is created and the node is created in init(). Can't really do this in on configure.

@bmagyar
Copy link
Member

bmagyar commented Sep 18, 2023

Good point! Thank you

@bmagyar bmagyar merged commit b7850f3 into master Sep 18, 2023
18 checks passed
@bmagyar bmagyar deleted the enable-services-for-log-level-in-controllers branch December 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants