Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A method to get node options to setup the controller node #api-breaking #1169

Merged
merged 10 commits into from
Jan 31, 2024
Merged

A method to get node options to setup the controller node #api-breaking #1169

merged 10 commits into from
Jan 31, 2024

Commits on Jan 23, 2024

  1. add a new method to be able to override the NodeOptions

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7c4b4cd View commit details
    Browse the repository at this point in the history

  2. update tests to use the new get_node_options API

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    39135c4 View commit details
    Browse the repository at this point in the history

  3. initialize URDF first to be able to retrieve parameters and override … 

    …in node options
    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    fbbdda5 View commit details
    Browse the repository at this point in the history

  4. added the API documentation of the new get_node_options method

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b8985d2 View commit details
    Browse the repository at this point in the history

  5. rename get_node_option to define_custom_node_options as per review su… 

    …ggestions
    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    143aa93 View commit details
    Browse the repository at this point in the history

  6. make init method arguments mandatory instead of using default

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5ef12fa View commit details
    Browse the repository at this point in the history

  7. Add more test cases for different NodeOptions

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7621fef View commit details
    Browse the repository at this point in the history

  8. fix linter error

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    abbf271 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Christoph Fröhlich <[email protected]>
    @saikishor @christophfroehlich
    saikishor and christophfroehlich committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    439eae0 View commit details
    Browse the repository at this point in the history

  10. remove virtual method as recommended by Denis

    @saikishor
    saikishor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a0c1341 View commit details
    Browse the repository at this point in the history