Fix unload of controllers when spawned with --unload-on-kill
#1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl,
erickisos,
livanov93 and
olivier-stasse
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1717 +/- ##
==========================================
+ Coverage 86.73% 86.75% +0.02%
==========================================
Files 116 116
Lines 10618 10628 +10
Branches 978 980 +2
==========================================
+ Hits 9209 9220 +11
+ Misses 1058 1057 -1
Partials 351 351
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
(cherry picked from commit 9e57adf) # Conflicts: # controller_manager/controller_manager/spawner.py # controller_manager/test/test_spawner_unspawner.cpp
mergify bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
(cherry picked from commit 9e57adf) # Conflicts: # controller_manager/test/test_spawner_unspawner.cpp
This was referenced Nov 3, 2024
saikishor
added a commit
that referenced
this pull request
Nov 3, 2024
saikishor
added a commit
that referenced
this pull request
Nov 3, 2024
saikishor
added a commit
that referenced
this pull request
Nov 3, 2024
#1843) Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
added a commit
that referenced
this pull request
Nov 3, 2024
#1842) Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug, when using
--unload-on-killoption, the spawner only unloads the last controller instead of all the controllers. This PR proposes a solution to fix the above issue