Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service call timeout argument in spawner #1808

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonynajjar
Copy link
Contributor

This PR exposes the call_timeout of the spawner to be optionally set by the user

Angsa Deployment Team added 2 commits October 22, 2024 12:02
Signed-off-by: Angsa Deployment Team <[email protected]>
Signed-off-by: Angsa Deployment Team <[email protected]>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (d55def1) to head (26c79d3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1808   +/-   ##
=======================================
  Coverage   87.62%   87.63%           
=======================================
  Files         120      120           
  Lines       12217    12224    +7     
  Branches     1093     1093           
=======================================
+ Hits        10705    10712    +7     
  Misses       1123     1123           
  Partials      389      389           
Flag Coverage Δ
unittests 87.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 74.62% <100.00%> (ø)
controller_manager/controller_manager/spawner.py 72.22% <100.00%> (+0.44%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please rebase/merge on master and update the release_notes and docs as I've done in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants