Add few warning compiler options to error (backport #1181)

[mergify]

Inspiring from the PRs that @destogl made recently: #1173 & #1174. I think it is in the best interest of everyone to add some compiler flags to errors to better code quality. I have done it for the most important packages and fixed some errors at the same time

---

This is an automatic backport of pull request #1181 done by Mergify.

[mergify]

Cherry-pick of 65353ff has failed:

On branch mergify/bp/humble/pr-1181
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 65353ff.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hardware_interface/src/mock_components/generic_system.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_interface/CMakeLists.txt
	both modified:   controller_manager/CMakeLists.txt
	both modified:   controller_manager/src/controller_manager.cpp
	both modified:   hardware_interface/CMakeLists.txt
	both modified:   hardware_interface_testing/test/test_resource_manager.cpp
	both modified:   joint_limits/CMakeLists.txt
	both modified:   transmission_interface/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 62.57%. Comparing base (24fcfe7) to head (bb6e50f).
Report is 1 commits behind head on humble.

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	54.54%	9 Missing and 1 partial ⚠️
...e_interface_testing/test/test_resource_manager.cpp	20.00%	0 Missing and 8 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           humble    #1816      +/-   ##
==========================================
- Coverage   62.58%   62.57%   -0.01%     
==========================================
  Files         108      108              
  Lines       12027    12024       -3     
  Branches     8129     8131       +2     
==========================================
- Hits         7527     7524       -3     
  Misses        880      880              
  Partials     3620     3620              

Flag	Coverage Δ
unittests	62.57% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...e_interface/src/mock_components/generic_system.cpp	80.00% <100.00%> (ø)
...e_interface_testing/test/test_resource_manager.cpp	64.43% <20.00%> (ø)
controller_manager/src/controller_manager.cpp	66.49% <54.54%> (-0.09%)	⬇️

[christophfroehlich]

This fixes #1588 locally for me (don't ask me why).

[saikishor]

LGTM