-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lifecycle nodes in controllers again #538
Use lifecycle nodes in controllers again #538
Conversation
The only thing left in this should be a test failure where we try to reconfigure and start an unconfigured loaded controller, the cli exits. I suspect that due to a cleanup error. |
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp
Show resolved
Hide resolved
@bmagyar I think I addressed all your review, but still I have one failing test in spawner_unspawner and controller_manager_srvs that seems to be stemming from cleanup. See https://github.com/ros-controls/ros2_control/runs/3663696172?check_suite_focus=true#step:3:3170 and https://github.com/ros-controls/ros2_control/runs/3663696172?check_suite_focus=true#step:3:3076 for context. |
I guess this is not gonna get merged soon, and I am more likely to not commit a lot of time into this PR, so closing it. Let me know if you need this or have any intentions to merge. |
This pull request is in conflict. Could you fix it @vatanaksoytezer? |
@vatanaksoytezer I will take this over. I hope I have access to push to your fork. Thanks for the initial work. It looks good. |
You should have access, let me know if you need anything. |
f7d506c
to
7d1be3c
Compare
57a63ba
to
858b210
Compare
858b210
to
dc0c59a
Compare
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Denis Štogl <[email protected]>
Adds the lifecycle nodes back, that are removed in #261.