Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full functionality of chainable controllers #667

Merged
merged 31 commits into from
Jun 30, 2022
Merged

Full functionality of chainable controllers #667

merged 31 commits into from
Jun 30, 2022

Commits on May 15, 2022

  1. Extending ControllerInterface with methods for chainable controllers. 

    Update structure of chainable controller to allow mode chaning only in 'UNCONFIGURED' state.

Switching to chained_mode is only forbidden if controller is active.

Add default implementation for 'on_set_chained_mode' method.

Avoid compile warning about unused variables.

Added check if all reference interface storage is initialized and that interface prefix is equal to controller's name.

Optimize tests and 'usings'.

Use two internal methods instead of 'update' directly on chained controllers.

Reorder constructor.
    @destogl
    destogl committed May 15, 2022
    Configuration menu
    Copy the full SHA
    d19c724 View commit details
    Browse the repository at this point in the history

  2. Add ControllerInterfaceBase class and use it in Controller Manager.

    @destogl
    destogl committed May 15, 2022
    Configuration menu
    Copy the full SHA
    03ae2b2 View commit details
    Browse the repository at this point in the history

  3. Make nice user interface to export controllers.

    @destogl
    destogl committed May 15, 2022
    Configuration menu
    Copy the full SHA
    c5d7383 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Revert some changes to work on this stage.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    862987e View commit details
    Browse the repository at this point in the history

  2. Extend resource manager to manage reference interfaces from controllers.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0b7bd7f View commit details
    Browse the repository at this point in the history

  3. Adjust interface between CM and RM for managing controllers' referenc… 

    …e interfaces.
    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    2a4af6b View commit details
    Browse the repository at this point in the history

  4. Small fixes in controller manager tests.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    44b17e0 View commit details
    Browse the repository at this point in the history

  5. Added first tests up to configuration of chainable controllers.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    b0cc0a7 View commit details
    Browse the repository at this point in the history

  6. Chained controllers can be manually activated.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    f883120 View commit details
    Browse the repository at this point in the history

  7. Successful value propagation when controllers are updated individually 🎉

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0a46e6c View commit details
    Browse the repository at this point in the history

  8. Successful updating all controllers at once when added into execution… 

    … order.🎊
    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    1b16a1b View commit details
    Browse the repository at this point in the history

  9. Add support for 'chained_controllers' parameter.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    50fee31 View commit details
    Browse the repository at this point in the history

  10. Split test into smaller reusable chunks and start test for auto-switc… 

    …hing chained mode.
    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a3f928d View commit details
    Browse the repository at this point in the history

  11. Make code of controller manager more readable and better documented.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a0b64da View commit details
    Browse the repository at this point in the history

  12. Added functionality for auto-switching of chained mode in controllers.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    1b05bf2 View commit details
    Browse the repository at this point in the history

  13. Fixed and optimization for running example.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    5d7b040 View commit details
    Browse the repository at this point in the history

  14. Added interface-matching approach for managing chaining controllers.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    fac6a89 View commit details
    Browse the repository at this point in the history

  15. Clean controller manager from obsolte code using parameter for chaine… 

    …d controllers.
    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a2be1d1 View commit details
    Browse the repository at this point in the history

  16. Return error is chained controller does not export any interfaces

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0348e8d View commit details
    Browse the repository at this point in the history

  17. Update chainable controller for tests.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    ed0d8d6 View commit details
    Browse the repository at this point in the history

  18. Add ControllerInterfaceBase class and use it in Controller Manager.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    648d039 View commit details
    Browse the repository at this point in the history

  19. Make nice user interface to export controllers.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    65bcd7c View commit details
    Browse the repository at this point in the history

  20. Fixup tests to the new API.

    @destogl
    destogl committed May 16, 2022
    Configuration menu
    Copy the full SHA
    cad977b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Merge branch 'master' into chainable-controllers

    @destogl
    destogl authored May 17, 2022
    Configuration menu
    Copy the full SHA
    1cb9154 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Merge branch 'master' into chainable-controllers

    @destogl
    destogl authored May 18, 2022
    Configuration menu
    Copy the full SHA
    b0ff012 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. Format code using clang-format-12 to make resolution of merge conflic… 

    …ts simpler.
    @destogl
    destogl committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    d652a34 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into chainable-controllers

    @destogl
    destogl authored Jun 18, 2022
    Configuration menu
    Copy the full SHA
    8ead608 View commit details
    Browse the repository at this point in the history

  3. Make trivial changes according to review comments.

    @destogl
    destogl committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    4b81f80 View commit details
    Browse the repository at this point in the history

  4. Update switch_chained_mode methods per review.

    @destogl
    destogl committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    fe20955 View commit details
    Browse the repository at this point in the history

  5. Move checks for chained controllers into separate methods.

    @destogl
    destogl committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    702f69f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Second round of reviews.

    @destogl
    destogl committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    e6d2f23 View commit details
    Browse the repository at this point in the history