Add ControllerInterfaceBase class with methods for chainable controller #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bijoua29,
bmagyar,
duringhof,
malapatiravi and
progtologist
destogl
changed the title
bmagyar
reviewed
May 15, 2022
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
destogl
commented
May 15, 2022
destogl
commented
May 15, 2022
controller_interface/include/controller_interface/controller_interface.hpp
Show resolved
Hide resolved
destogl
commented
May 15, 2022
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
destogl
commented
May 15, 2022
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
destogl
commented
May 15, 2022
controller_interface/include/controller_interface/controller_interface_base.hpp
Outdated
Show resolved
Hide resolved
destogl
commented
May 15, 2022
bmagyar
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the disucssion in #663 (#663 (review)), and on destogl#11 this PR introduces a new base class for controllers interfaces from which "normal" controller implementing
ControllerInterfaceand "chainable controllers" implementingChainableControllerInterfaceare derived.In the second commit loading of controllers inside controller manager is updated resulting that users export their controllers as usual, using
ControllerInterfaceand notControllerInterfaceBaseclass.This provides nice user API. (This will then also enable users to export plugins for chained controllers using
ChainableControllerInterfaceclass).