Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds coverage.py #115

Merged
merged 24 commits into from
Aug 14, 2024
Merged

Adds coverage.py #115

merged 24 commits into from
Aug 14, 2024

Conversation

christophfroehlich
Copy link
Contributor

This is necessary to get branch coverage of python files called within c++ tests.

@christophfroehlich
Use also pytest for coverage build
83ee39d
@christophfroehlich
Install lcov
09c6c18
@christophfroehlich
Install pytest-cov
d1cacbf
@christophfroehlich
Fix codecov key
43eef73
@christophfroehlich
Add debug list for coverage tools
1d7c244
@christophfroehlich
Fix debug entry
c4aad66
@christophfroehlich
Install coverage.py also via pip and print version
19fd2d3
@christophfroehlich
Install pip itself
28bfc7d
@christophfroehlich
Use virtual environments
b98d483
@christophfroehlich
Source ist not available in sh
712f771
@christophfroehlich
Try to use the venv in later steps
9642a34
@christophfroehlich
combine .coverage files
43d0f4b
@christophfroehlich
More debug outputs
4bff50a
@christophfroehlich
upgrade coverage.py and specify controller_manager coverage manually
f2f27d2
@christophfroehlich
use bash for install
2dead42
@christophfroehlich
Cleanup
ab46ea6
@christophfroehlich
Only state the workspace folder, let codecov-cli look for supported f…
38fedb6 
…iles
@christophfroehlich
Manually convert to xml
a6e5f84
@christophfroehlich
Why is coverage not available any more?
5b4b8f5
@christophfroehlich
pwd
9434a87
@christophfroehlich
Don't stop
f5268f7
@christophfroehlich
Can I install the venv in the user folder?
4f9a46d
@christophfroehlich
Cleanup
5af3b8c
@christophfroehlich christophfroehlich mentioned this pull request Aug 14, 2024
Merged
@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented Aug 14, 2024 •
edited
Loading

@fmauch I had to fight the venv settings, it seems that action-ros-ci cleans the workspace and a venv created in .venv does not exist afterwards (this is why I create it now in the user folder ~/.venv).

and still the codecov-action does not find the coverage.py and throws this warning

https://github.com/codecov/codecov-cli/blob/1478514b1203d1c3921ca60b767c4224d0c417e4/codecov_cli/plugins/pycoverage.py#L58-L60

Maybe you see an obvious issue with these changes or have other suggestions..

bmagyar
bmagyar approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit d3367be into master Aug 14, 2024
2 checks passed
@bmagyar bmagyar deleted the coveragepy branch August 14, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@fmauch fmauch Awaiting requested review from fmauch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @bmagyar