Updates for noble

[christophfroehlich]

Using the last version of setup-ros fixed it for noble, if the correct container is used. These PR adds changes for all usages of setup-ros to make that work for our workflows.

Needs container: ubuntu:24.04 until the github runner will be updated, but the workflows should work automatically if ubuntu-latest is bumped to 24.04 and no container input is given.

Fixes #51 and #13

[christophfroehlich]

We need a noble image for fixing that, see https://github.com/ros-controls/realtime_tools/actions/runs/8745182563/job/23999673020?pr=163

The official github image will probably be released next week actions/runner-images#9691, I'd wait for that.
@fmauch Or should we use one from osrf and skip the setup-ros step?

[fmauch]

As far as I understand the discussion the runner image will be in public beta next week, so it probably won't be available through runs-on: ubuntu-24.04. Hence, it might actually be a good idea to use the OSRF one.

[christophfroehlich]

I had a quick look, but that's not that easy..

• using a bare ubuntu:noble container needs lots of steps to get ROS running (no surprise)
• using OSRF's ros:rolling-ros-core-noble still needs lots of additional steps, I don't understand why for example even after setup-ros rosdep is not available.

Not sure if we should merge this, or wait until a simpler workflow will work again

jobs:
  coverage:
    name: coverage build
    uses: ros-controls/ros2_control_ci/.github/workflows/reusable-build-coverage.yml@revert_coverage_hack
    secrets: inherit
    with:
      ros_distro: rolling
      os_name: ubuntu-22.04
      container: ros:rolling-ros-core-noble

[christophfroehlich]

[email protected] now supports noble (#55). Needs container: ubuntu:24.04 or container: ros:rolling-ros-core-noble until ubuntu-latest runner is available from github.

Should we merge this and change all calling workflows, or wait until ubuntu-latest is noble? Same question for all the source build workflows.

[fmauch]

Great news :-)

I don't necessarily see a downside from merging this in now.

[christophfroehlich]

Then I'll merge this and create PRs for the calling workflows to add the images. I don't see any problems to leave the images there until the next ubuntu?

[christophfroehlich]

or does this significantly increase bandwidth/CI time to pull the images instead of using the GH runner directly?

[christophfroehlich]

It took me some time to fix that stuff with the containers, but I think now it could work:
https://github.com/ros-controls/realtime_tools/actions/runs/8806905250/job/24173586181?pr=163
https://github.com/ros-controls/realtime_tools/actions/runs/8806905242/job/24172740002?pr=163
https://github.com/ros-controls/realtime_tools/actions/runs/8807283330/job/24173987066?pr=163

[fmauch]

Looks good, thanks for all the work you put into this!

[saikishor]

@christophfroehlich Thank you :)

[christophfroehlich]

now come the next 10 PRs for setting the correct image :p