-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI load_controller verb #585
Conversation
@christophfroehlich should we wait for the binary release? |
No, because the master version is neither working with the current release, or am I wrong? |
Well in theory, the PR: ros-controls/ros2_control#1703 is merged already. The current failing builds are both binary builds (main and testing) |
But I mean the 1703 is not included in the 4.17 release. And the current version of load_controller from the head of ros2_control_demos is not working with 4.17 |
Shall we wait for the release then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The part of the demo is not working at all without merging this PR 😬 after merge, at least it works for users with source builds. And I can live with red CI of the binary builds. |
This fixes the CLI commands of example_1 with the new option introduced with ros-controls/ros2_control#1703
Fixes #555