-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug for displaying all controllers #1259
Fix bug for displaying all controllers #1259
Conversation
Signed-off-by: Francisco Martín Rico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
@fmrico can you apply the pre-commit formatting changes |
Signed-off-by: Francisco Martín Rico <[email protected]>
Hi @saikishor !! Changes applied. Let's wait for CI |
and let's see the CI after Christoph's updates ;) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 105 105
Lines 9357 9356 -1
Branches 821 819 -2
=======================================
Hits 7523 7523
- Misses 1557 1558 +1
+ Partials 277 275 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit 3be3fe9) # Conflicts: # rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
(cherry picked from commit 3be3fe9) # Conflicts: # rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
Hi,
When using the rqt_joint_trajectory_controller, not all the controllers are shown on the controller button. This is because the list of limits was not accumulated, and only the last one was considered. This PR fixes this, showing all the valid controllers.
I hope it helps
Francisco