[JSB] Fix the behaviour of publishing unavailable state interfaces when they are previously available #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
erickisos,
mcbed,
moriarty and
olivier-stasse
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
+ Coverage 80.57% 80.67% +0.10%
==========================================
Files 109 109
Lines 9553 9580 +27
Branches 832 835 +3
==========================================
+ Hits 7697 7729 +32
+ Misses 1578 1573 -5
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Oct 31, 2024
bmagyar
added
backport-humble
christophfroehlich
approved these changes
Nov 1, 2024
christophfroehlich
merged commit 87f21b3
into
ros-controls:master
18 of 20 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
…en they are previously available (#1331) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3)
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
…en they are previously available (#1331) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3)
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 1, 2024
…en they are previously available (#1331) (#1339) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3) Co-authored-by: Sai Kishor Kothakota <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 1, 2024
…en they are previously available (#1331) (#1340) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3) Co-authored-by: Sai Kishor Kothakota <[email protected]>
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While reviewing the Example 13, I came across this situation described in the comment : ros-controls/ros2_control_demos#417 (comment)
After debugging, the resource manager properly sets the state interfaces. However, some internal variables are not properly reset, and this results in the publishing of previously available interfaces.
The proposed fix fixes the issue of properly publishing the state of the known state interfaces alone