CompositeController template for easy combining of controllers #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepurvis
force-pushed
the
composite-controller
branch
from
3149aa6
to
8a51fc6
Compare
|
Could you rebase this one please? |
mikepurvis
force-pushed
the
composite-controller
branch
from
8a51fc6
to
1f87b27
Compare
|
Done. |
|
Looks like we have a dependency-wait issue on Melodic. However, the fact that this passed on Kinetic probably indicates inadequate test coverage. :) |
|
Ok so this PR will remain off the first Melodic release until we have more tests, right? |
|
It definitely works— we've been using it on a new robot internally for several weeks. And it's also new functionality, so safe to merge in that sense also. However, if you want to hold it to keep me honest, I won't be at all offended. |
This was referenced Aug 1, 2019
|
Closed in favour of #387. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on #290 and #299, and demonstrates a generic template using the
public virtualchange to allow multiple controllers with polymorphic extension points to be easily combined into a monolithic co-operative controller.Here for discussion for the moment; more docs and tests to come.