Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to check for error in robotHW component #357

Open
wants to merge 2 commits into
base: melodic-devel
Choose a base branch
from

Conversation

bochen87
Copy link

I'm proposing to add a method to check for errors in the hardware components, especially when having multiple HW components, it becomes quite cumbersome otherwise.

@bmagyar
Copy link
Member

bmagyar commented Sep 25, 2018

Could you please demonstrate an example use-case, perhaps through some unit tests?

@bochen87
Copy link
Author

bochen87 commented Oct 4, 2018

@bmagyar added a very basic test to it. I guess could also be very useful in conjunction with #294 to then automatically attempt to recover / stop

@mathias-luedtke
Copy link
Contributor

Who would call this hasError function and why?

@bochen87
Copy link
Author

bochen87 commented Oct 4, 2018

At the moment I use this in the main loop and then attempt to recover / stop if it returns true.

@mathias-luedtke
Copy link
Contributor

attempt to recover / stop if it returns true.

This is the interesting part.. I believe there are no interfaces for this yet.
In ros_canopen I poll and command the hardware directly.

@bochen87
Copy link
Author

bochen87 commented Oct 4, 2018

No, there is no interface for that yet - that's why I would like to see #294 being extended to combined_robot_hw and also merged.
Maybe add the extension of stop / recover to combined_robot_hw and the error checking interface in one PR?

@bochen87
Copy link
Author

bochen87 commented Dec 5, 2018

@bmagyar @ipa-mdl any thoughts?

@jlack1987
Copy link
Contributor

Would just like to throw this out there in case nobody has considered it, but it appears the API is converging on an orocos component like design

@bochen87
Copy link
Author

@bmagyar @ipa-mdl any thoughts?

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants