Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement that voxel dimensions be multiples of 32 #42

Open
schornakj opened this issue Aug 7, 2020 · 0 comments
Open

Remove requirement that voxel dimensions be multiples of 32 #42

schornakj opened this issue Aug 7, 2020 · 0 comments

Comments

@schornakj
Copy link
Contributor

Yak PR 34 removed the assertion that the dimensions of the voxel volume be multiples of 32 after it was determined that the underlying CUDA code handled uneven voxel dimensions correctly.

The lines that check for this can be removed:
https://github.com/ros-industrial/yak_ros/blob/6aa7a39c19d930cbdeea55833ed74a45fa287bb4/yak_ros/src/yak_ros1_node.cpp#L322-L326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schornakj