-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options to ignore failing tests in prerelease #363
base: master
Are you sure you want to change the base?
add options to ignore failing tests in prerelease #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document these 2 variables new to ICI?
Other than that this LGTM. A clarification: What happens when a test fails while neither of ABORT_ON_TEST_FAILURE_{Over, UNDER}LAY
are passed (i.e. default behavior)? If this changes the default, that might be noted in the document?
This should het merged into the new version.
I will add some line to the documentation of the prerelease tests.
TL;DR: This patch does not change the default of In |
Is there any update? I might be willing to add documentation. As a "new user" to the recently added changes, I might be able to capture missing info well enough. If that's ok in general, I'm fine in moving forward in merging w/o including more documentation (in that case create follow-up ticket and assign me/anyone appropriate). |
This needs to be rebased, but it is prioritized Some notes on these flags could be added here:
|
closes #362
@wxmerkt: With this fix you can set ABORT_ON_TEST_FAILURE_UNDERLAY=0 to make your test pass