Add bw-compatibility to simple_message ifdefs #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some bw-compatibility to the changes merged in ros-industrial#262. Remove these in noetic-devel.
|
If any of you could review? I'll merge this with administrator access otherwise, but a second pair of eyes may be nice in this case. |
|
As I'd like to get a release in the current sync, I'm merging this. I've build-tested both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now (ie: in
melodicandmelodic-devel), accept the old#definesROSandLINUXSOCKETSin addition to the newer ones (ie: the namespaced ones).Should fix #274 and fix builds which haven't been updated to use the new
simple_message_DEFINITIONS.This was already suggested actually by @jdlangs in #190, but I removed it, hoping to get away with it in Melodic.
Unfortunately that didn't work, so here we are.