Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #define-based namespaces to prevent linking errors. #355

Open
wants to merge 4 commits into
base: kinetic-devel
Choose a base branch
from

Commits on Jun 8, 2018

  1. Added #define-based namespaces to prevent linking errors.

    In the current setup, it is impossible to link against the ur5 or ur10 versions of the kinematics library, as all expose the same ur_kinematics::inverse() signature.
    Since all libraries are exported in the catkin_package() macro, this results in undefined behavior when linking.
    GCC just picks the first suitable signature it encounters, in this case the ur3 version, and continues without an error.
    Adding a namespace allows the linker to find the correct library call.
    a-price committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    532123f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Configuration menu
    Copy the full SHA
    d3819f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4fec2b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a06798 View commit details
    Browse the repository at this point in the history