Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism for specifying additional arguments to 'docker run' #1064

Closed
wants to merge 1 commit into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 9, 2024

This change adds an escape hatch for passing additional arguments to 'docker run' invocations for release jobs. One possible motivation would be to mount local package repositories into the containers when running release jobs in script mode.

This change adds an escape hatch for passing additional arguments to
'docker run' invocations for release jobs. One possible motivation would
be to mount local package repositories into the containers when running
release jobs in script mode.
@cottsay cottsay self-assigned this Oct 9, 2024
@cottsay
Copy link
Member Author

cottsay commented Oct 9, 2024

My first shot at this changed only generate_release_script.py by appending arguments to any line that starts with docker run, but we have some invocations that have bash stuff happening later on the line. Additionally, I think we have to inject the arguments before the label is specified at the end.

@nuclearsandwich
Copy link
Contributor

One possible motivation would be to mount local package repositories into the containers when running release jobs in script mode.

This may require the use of a more specialized configuration to provide mount config for docker-build as well as docker-run since package installation during release jobs happens when building the docker container rather than during docker-run.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin, although I've left a comment on the proposed example use case as well.

@cottsay
Copy link
Member Author

cottsay commented Oct 11, 2024

...to provide mount config for docker-build as well as docker-run since package installation during release jobs happens when building the docker container...

I'm so mad I didn't see this sooner, but you're right. It renders the feature useless to me, so I think we should close the PR. We can always re-open it if we find a use for this functionality.

@cottsay cottsay closed this Oct 11, 2024
@cottsay cottsay deleted the cottsay/additional-docker-run-args branch October 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants