-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav2 3954 consider robot footprint #3990
Nav2 3954 consider robot footprint #3990
Conversation
Looks like the test failures are fixed with a pulling in of main or rebasing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3990 +/- ##
==========================================
- Coverage 90.41% 90.41% -0.01%
==========================================
Files 415 415
Lines 18569 18673 +104
==========================================
+ Hits 16789 16883 +94
- Misses 1780 1790 +10 ☔ View full report in Codecov by Sentry. |
621ca35
to
f47526f
Compare
f47526f
to
69239a2
Compare
This pull request is in conflict. Could you fix it @jwallace42? |
Basic Info
Description of contribution in a few bullet points
This pr adds functionality to invalidate a path based based on footprint checks. This functionality was added to the
isPathValid
service. A new parameter calledis_path_valid_check_footprint
was added to turn on/off the full footprint checks.Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: