Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AMCL dependency from RPP #4222

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

jncfa
Copy link
Contributor

@jncfa jncfa commented Mar 27, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4185
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Replaces the nav2_amcl::angleutils usage in RPP with angles and drops the dependency to nav2_amcl, which in this case was being used just for one angle normalization call.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Contributor

mergify bot commented Mar 27, 2024

@jncfa, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! A much better solution 😄

@SteveMacenski SteveMacenski merged commit f9828c2 into ros-navigation:main Mar 27, 2024
7 of 9 checks passed
ajtudela pushed a commit to grupo-avispa/navigation2 that referenced this pull request Apr 19, 2024
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
Signed-off-by: jncfa <[email protected]>
Signed-off-by: enricosutera <[email protected]>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants