[Windows][ROS2] Fixed Windows build issues #277
Conversation
|
It seemed to me that |
|
@gaoethan Hope I am pinging the correct owner. Can you help review/merge the change for fixing Windows build? |
|
The build is yellow because of the CMake warning w/r/t Boost. I think that's okay here. |
| @@ -5,6 +5,7 @@ ament_target_dependencies(${PROJECT_NAME} | |||
| "sensor_msgs" | |||
| ) | |||
| target_link_libraries(${PROJECT_NAME} ${Boost_LIBRARIES} ${OpenCV_LIBRARIES}) | |||
| set_target_properties(${PROJECT_NAME} PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON) | |||
There was a problem hiding this comment.
Should we be doing this or using visibility macros?
|
I think some of the I would like to get that landed, then I'll come back and look at this one. |
|
This would address #289, which I just opened, but I still don't understand why the Boost include only breaks the Windows build. Also, I was able to build without adding back the OpenCV include, so maybe that is no longer necessary since the PR was opened. |
|
Closed it and in favor of #301 |
This change is to address 2 issues found when I am building ROS2 Dashing from source.
Boost & OpenCV headers are not found at compile time because
${Boost_INCLUDE_DIRS}&${OpenCV_INCLUDE_DIRS}are not in the includes path.The imported library of
cv_bridge.libis not generated since no functions are dllexport'd fromcv_bridge, consequentlycv_bridge-utestfails to build when trying to link againstcv_bridge. UseWINDOWS_EXPORT_ALL_SYMBOLSto make every functions fromcv_bridgedllexport'd to fix it.