Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix find boost-python for cv_bridge #390

Closed
wants to merge 1 commit into from

Conversation

flynneva
Copy link
Contributor

@flynneva flynneva commented May 12, 2021

this should fix the cv_bridge build errors reported for windows #349.

obviously we should try to remove boost going forward for this package.

@flynneva
Copy link
Contributor Author

from this document:

Note that Boost Python components require a Python version suffix (Boost 1.67 and later), e.g. python36 or python27 for the versions built against Python 3.6 and 2.7, respectively. This also applies to additional components using Python including mpi_python and numpy. Earlier Boost releases may use distribution-specific suffixes such as 2, 3 or 2.7. These may also be used as suffixes, but note that they are not portable.

need to fix the version checks in the cmake file to make it work for Dashing it looks like

@flynneva
Copy link
Contributor Author

flynneva commented Jun 10, 2021

for anyone else who ends up here, boost 1_74_0 is the most recent boost release that still uses python 3.8 (compatible with Foxy).

@Ace314159
Copy link

I'd love if this could get merged. I've experienced this same issue, and I have a similar fix that works for me.

@Ace314159
Copy link

@mjcarroll Could you please merge this as well?

@mjcarroll
Copy link
Contributor

Replaced by #421

@mjcarroll mjcarroll closed this Jan 24, 2022
ijnek added a commit that referenced this pull request Sep 18, 2022
@ijnek ijnek mentioned this pull request Sep 19, 2022
mergify bot pushed a commit that referenced this pull request Sep 19, 2022
Signed-off-by: Kenji Brameld <[email protected]>
(cherry picked from commit ec1ac9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants