Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13 #14

Open
wants to merge 3 commits into
base: indigo-devel
Choose a base branch
from
Open

Fixes #13 #14

wants to merge 3 commits into from

Conversation

czyapp
Copy link

@czyapp czyapp commented Jul 15, 2017

The map now matches in stage and RVIZ for move_base_fake_localization_5cm. I will look into the 2.5cm and 10cm maps when I have time.

The map now matches in stage and RVIZ for move_base_fake_localization_5cm. I will look into the 2.5cm and 10cm maps when I have time.
@czyapp czyapp changed the title Fixes #13 for 5cm map only Fixes #13 Jul 15, 2017
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I need to run the other tutorials. I think there was an issue where the map or world files were being used by multiple launch files but with different settings. I want to make sure we're not just flipping between possible states.

Thanks for the pr.

@czyapp
Copy link
Author

czyapp commented Jul 15, 2017

Yea I supposed so. It's the orientation and position of the map that's causing the problem so I'm not surprised if those are the configuration for other tutorials. I only checked them within the navigation tutorial itself (because that's what I'm learning atm). WIll definitely come back if I found any other issues. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants