Support private repos #224
Labels
enhancement
New feature or request
Comments
emersonknapp
added a commit
that referenced
this issue
Jul 21, 2020
This adds a new 'import-token' input to be used when importing a private repo. Otherwise the step fails with the following error on 'vcs import', since it tries to read a username and a password from stdin: fatal: could not read Username for 'https://github.com': No such device or address The token is used in the HTTPS URL itself, e.g.: https://[token@]github.com/user/repo.git Note that this doesn't use the approach suggested in #224. This is more of a simple workaround given the current logic. Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Anas Abou Allaban <[email protected]> Co-authored-by: Emerson Knapp <[email protected]>
jikawa-az
pushed a commit
that referenced
this issue
Jul 22, 2020
This adds a new 'import-token' input to be used when importing a private repo. Otherwise the step fails with the following error on 'vcs import', since it tries to read a username and a password from stdin: fatal: could not read Username for 'https://github.com': No such device or address The token is used in the HTTPS URL itself, e.g.: https://[token@]github.com/user/repo.git Note that this doesn't use the approach suggested in #224. This is more of a simple workaround given the current logic. Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Anas Abou Allaban <[email protected]> Co-authored-by: Emerson Knapp <[email protected]> Signed-off-by: Jesse Ikawa <[email protected]>
jikawa-az
pushed a commit
that referenced
this issue
Jul 22, 2020
This adds a new 'import-token' input to be used when importing a private repo. Otherwise the step fails with the following error on 'vcs import', since it tries to read a username and a password from stdin: fatal: could not read Username for 'https://github.com': No such device or address The token is used in the HTTPS URL itself, e.g.: https://[token@]github.com/user/repo.git Note that this doesn't use the approach suggested in #224. This is more of a simple workaround given the current logic. Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Anas Abou Allaban <[email protected]> Co-authored-by: Emerson Knapp <[email protected]> Signed-off-by: Jesse Ikawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As stated in the README,
action-ros-cichecks out code usingvcs import, which doesn't seem to work for private GitHub repos.Related Issues
While
actions/checkout@v2supports checking out private GitHub repos, the example in the README only uses that checked out repo for generating a*.reposfile;action-ros-cidoesn't actually build that checked out code.Completion Criteria
Be able to use
action-ros-cion a private GitHub repo.Implementation Notes / Suggestions
Probably make use of the code that
actions/checkout@v2checks out. I think this behavior is also more intuitive for a GitHub actions user, that the code fromactions/checkout@v2is actually the code subsequently being built bycolcon, not a copy of the code that came fromvcs import.The text was updated successfully, but these errors were encountered: